Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions, and warnings - Text #773

Merged
merged 8 commits into from
Jan 18, 2022

Conversation

ashutoshml
Copy link
Contributor

@ashutoshml ashutoshml commented Jan 18, 2022

What does this PR do?

Fixes part of #771

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ashutoshml ashutoshml changed the title Remove deprecated functions, and warnings Remove deprecated functions, and warnings - Text Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #773 (d9075ec) into master (b8e67f9) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #773   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         171    171           
  Lines        6926   6883   -43     
=====================================
- Hits         6546   6522   -24     
+ Misses        380    361   -19     

@Borda Borda added the enhancement New feature or request label Jan 18, 2022
@Borda Borda added this to the v0.8 milestone Jan 18, 2022
@mergify mergify bot added the ready label Jan 18, 2022
@Borda Borda mentioned this pull request Jan 18, 2022
4 tasks
@Borda Borda merged commit 0848523 into Lightning-AI:master Jan 18, 2022
Borda added a commit that referenced this pull request Jan 18, 2022
* Remove deprecated functions, and warnings
* Update links for docstring
* chlog

Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@ashutoshml ashutoshml deleted the prunedeprecated branch January 19, 2022 01:05
Borda added a commit that referenced this pull request Jan 19, 2022
* Remove deprecated functions, and warnings
* Update links for docstring
* chlog

Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda added a commit that referenced this pull request Jan 19, 2022
* Remove deprecated functions, and warnings
* Update links for docstring
* chlog

Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants